Skip to content

Refactor code tree matchers#683

Closed
mezpusz wants to merge 34 commits intomasterfrom
refactor-code-tree-matchers
Closed

Refactor code tree matchers#683
mezpusz wants to merge 34 commits intomasterfrom
refactor-code-tree-matchers

Conversation

@mezpusz
Copy link
Contributor

@mezpusz mezpusz commented Apr 8, 2025

CodeTree has two matcher implementations, even though they do almost the same thing. This PR merges them with some compile-time branching, so there should be no noticable overhead.

Usual sampled testing done for 20 iterations of the entire TPTP, no errors (so far).
Performance testing showed a miniscule amount of slowdown for some problems, I think it's just noise after testing them a couple of times locally.

mezpusz added 28 commits June 26, 2024 14:51
…r); add options for AVATAR and literal conditions
…, confluence trees, mergable leaves in code trees
@mezpusz
Copy link
Contributor Author

mezpusz commented Apr 8, 2025

Maybe squashing the commits would make sense as this originates from some unrelated branch, the contents of which were merged or discarded already.

@MichaelRawson
Copy link
Contributor

@mezpusz - any reason for this to be on hold? Looks like something we want.

@mezpusz
Copy link
Contributor Author

mezpusz commented Jan 21, 2026

There was a slight performance worsening (<10 problems lost), so it was just left as undecided. I can rerun it to see how it goes now.

@MichaelRawson
Copy link
Contributor

Thanks for the update! It would be good to work out what went wrong with those 10 problems. Otherwise I'm happy to merge.

@mezpusz
Copy link
Contributor Author

mezpusz commented Jan 21, 2026

Currently it's just one problem lost for Discount, none for Otter over FOL with -i 20000, but there is an increase in instructions spent/runtime apparently:

Discount:

run 0 unsat: 9208 (1) sat: 1030 (0) cputime: 56704.85 s instructions: 222910720 Mi memory: 1533982.30 MB
run 1 unsat: 9207 (0) sat: 1030 (0) cputime: 57026.97 s instructions: 222964103 Mi memory: 1529041.49 MB

Otter:

run 0 unsat: 9312 (0) sat: 1020 (0) cputime: 61537.83 s instructions: 222902233 Mi memory: 1739725.78 MB
run 1 unsat: 9312 (0) sat: 1020 (0) cputime: 61743.87 s instructions: 222978995 Mi memory: 1731210.00 MB

The problem lost is LCL/LCL640+1.015.p, and it is solved with 153 extra megainstructions.

So... 🤷

@MichaelRawson
Copy link
Contributor

Then...I don't care personally, @quickbeam123 ?

@quickbeam123
Copy link
Collaborator

Sure, let's go! We need more code trees :)

@MichaelRawson
Copy link
Contributor

Can you cleanup the history where it would make sense, @mezpusz ? Then I'm happy to merge.

@mezpusz
Copy link
Contributor Author

mezpusz commented Jan 24, 2026

@MichaelRawson can you please "squash and merge" the PR? I'm okay with having just one commit, and locally it seems to be hellish to do.

MichaelRawson added a commit that referenced this pull request Jan 24, 2026
@MichaelRawson
Copy link
Contributor

Gross - I usually just rebase onto master and then merge, but I hadn't encountered this particular scenario before. 🤷 I'll work out how to do it properly for next time. Thanks!

(please do claim credit - git commit --amend --reset-author and then force-push)

@MichaelRawson
Copy link
Contributor

Merged.

@mezpusz
Copy link
Contributor Author

mezpusz commented Jan 24, 2026

No worries, and thanks for the merge. This branch was a bit cursed anyways, I'll try to organize changes a bit more tidily next time. 😀

@mezpusz mezpusz deleted the refactor-code-tree-matchers branch January 24, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants