Conversation
…r); add options for AVATAR and literal conditions
…, confluence trees, mergable leaves in code trees
|
Maybe squashing the commits would make sense as this originates from some unrelated branch, the contents of which were merged or discarded already. |
|
@mezpusz - any reason for this to be on hold? Looks like something we want. |
|
There was a slight performance worsening (<10 problems lost), so it was just left as undecided. I can rerun it to see how it goes now. |
|
Thanks for the update! It would be good to work out what went wrong with those 10 problems. Otherwise I'm happy to merge. |
|
Currently it's just one problem lost for Discount, none for Otter over FOL with Discount: run 0 unsat: 9208 (1) sat: 1030 (0) cputime: 56704.85 s instructions: 222910720 Mi memory: 1533982.30 MB Otter: run 0 unsat: 9312 (0) sat: 1020 (0) cputime: 61537.83 s instructions: 222902233 Mi memory: 1739725.78 MB The problem lost is So... 🤷 |
|
Then...I don't care personally, @quickbeam123 ? |
|
Sure, let's go! We need more code trees :) |
|
Can you cleanup the history where it would make sense, @mezpusz ? Then I'm happy to merge. |
|
@MichaelRawson can you please "squash and merge" the PR? I'm okay with having just one commit, and locally it seems to be hellish to do. |
|
Gross - I usually just rebase onto master and then merge, but I hadn't encountered this particular scenario before. 🤷 I'll work out how to do it properly for next time. Thanks! (please do claim credit - |
|
Merged. |
|
No worries, and thanks for the merge. This branch was a bit cursed anyways, I'll try to organize changes a bit more tidily next time. 😀 |
CodeTreehas two matcher implementations, even though they do almost the same thing. This PR merges them with some compile-time branching, so there should be no noticable overhead.Usual sampled testing done for 20 iterations of the entire TPTP, no errors (so far).
Performance testing showed a miniscule amount of slowdown for some problems, I think it's just noise after testing them a couple of times locally.